avadev / AvaTax-REST-V2-PHP-SDK

Sales Tax API SDK for PHP and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
48 stars 96 forks source link

How do I specify a unit for parameters that accept units? #155

Closed chamby closed 2 years ago

chamby commented 3 years ago

I am trying to add a NetWeight parameter that accepts a value and unit according to the documentation.

The code does not seem to allow this:

https://github.com/avadev/AvaTax-REST-V2-PHP-SDK/blob/3567dd5ce251ec11978cd495478e19b9cd97c10b/src/TransactionBuilder.php#L228-L243

chamby commented 3 years ago

Other language SDKs seem to support this:

https://github.com/avadev/AvaTax-REST-V2-DotNet-SDK/blob/0ed11cc2aef81e4466487167bfa75e307ebbb305/src/TransactionBuilder.cs#L150-L168

svc-developer commented 2 years ago

This issue was addressed as part of https://github.com/avadev/AvaTax-REST-V2-PHP-SDK/pull/177. Please verify and let us know if you still happen to see any issue.