avadev / AvaTax-REST-V2-PHP-SDK

Sales Tax API SDK for PHP and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
48 stars 95 forks source link

Missing method to set $this->_model['email '] (Customer Email) #214

Closed ScottishDarren closed 6 days ago

ScottishDarren commented 8 months ago

The PHP class TransactionBuilder does not have a method to set the customer email.

The .NET class has this available: https://github.com/avadev/AvaTax-REST-V2-DotNet-SDK/blob/master/src/TransactionBuilder.cs

line 812:

public TransactionBuilder WithEmail(string email)
        {
            _model.email = email;
            return this;
        }

There is no equivalent method in the PHP class. To add this method, this file must be adjusted: https://github.com/avadev/AvaTax-REST-V2-PHP-SDK/blob/master/src/TransactionBuilder.php

Example code for new method:

    /**
     * Set a customer email
     *
     * @param   string              email
     * @return  TransactionBuilder
     */
    public function withEmail($email)
    {
        $this->_model['email'] = $email;
        return $this;
    }
svc-developer commented 2 months ago

@ScottishDarren Feel free to create a PR for this if you'd like to add it, we would be happy to merge. Otherwise, we will address this time permitting. Thanks!

svc-developer commented 6 days ago

Released in 24.8.2