avadev / AvaTax-REST-V2-PHP-SDK

Sales Tax API SDK for PHP and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
48 stars 95 forks source link

commitTransaction method not behaving as expected, has incorrect inline documentation #215

Closed ftrudeau-pelcro closed 6 days ago

ftrudeau-pelcro commented 7 months ago

The inline documentation for the commitTransaction method states that it's should be used for committing a transaction for reporting and marking it as Committed by changing its status.

The $transactionCode is passed to this method, so why must both the $documentType and $model be provided when using it event if your inline documentation mentions that $documentType is optional (in the DocBlock) ?

I assumed this method can be used to change the status from Saved to Committed, for an existing transaction in Avalara. If so, then I should not have to re-build the model, the transaction already exists and was Saved in Avalara. All I want to do is change it's status.

What am I missing?

If this is not the correct method to change the status of an existing transaction from Saved to Committed, which method should I use?

Thanks

svc-developer commented 1 month ago

@ftrudeau-pelcro I believe this is the correct method to use, I have a fix that will mark the other attributes as optional that will go in the next SDK release in July

svc-developer commented 6 days ago

Released in 24.8.2