search

avadev / AvaTax-REST-V2-PHP-SDK

Sales Tax API SDK for PHP and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
48 stars 95 forks source link

listTransactionsByCompany in Methods.php should make $dataSourceId an optional parameter #219

Open shilpsauce opened 4 weeks ago

shilpsauce commented 4 weeks ago

The $dataSourceId is not required for the API call, so the $dataSourceId should become an optional parameter for this function. I'd be happy to submit a pull request if it will be reviewed and incorporated.

svc-developer commented 2 weeks ago

@shilpsauce Will reach out to API team on this issue, as generation is driven from swagger file, a PR will get overwritten whenever we regenerate.

svc-developer commented 1 week ago

@shilpsauce I identified the issue and the fix will go in the next SDK release in July