search

avadev / AvaTax-REST-V2-Ruby-SDK

Sales Tax API SDK for Ruby and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
36 stars 56 forks source link

Fix regex for filtering credentials from logs #106

Open starsirius opened 3 years ago

starsirius commented 3 years ago

The ending "=" character of a base64 encoded string is padding. When the input length is a multiple of three (which is the case for our account id and license key pair), the output would not have the padding character. This results in our credentials not being filtered in the logs.

This fixes the regex by removing the incorrect assumption.

starsirius commented 3 years ago

Looks like CI is no longer running and will need to migrate from travis-ci.org to travis-ci.com.

starsirius commented 3 years ago

@shilpakhanal I see you are the most recent contributor to this project. We're in the process of integrating the SDK with our app. Do you mind helping us get this PR reviewed and hopefully merged (or directing us to the right person/process)? Thank you! 🙏