avadev / AvaTax-REST-V2-Ruby-SDK

Sales Tax API SDK for Ruby and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
36 stars 56 forks source link

Fix syntax of transaction in example code #34

Closed zreisman closed 5 years ago

zreisman commented 6 years ago

Current syntax is invalid.

marcus commented 6 years ago

This hash syntax has been supported in ruby since 1.9. Curious why you believe it’s inavalid.

joelvh commented 6 years ago

Maybe because the keys are symbols and he wants them to be strings?

zreisman commented 6 years ago

A trailing colon instead of a hash rocket is valid. It isn't valid combined with the quote. "key": "value"

screen shot 2018-10-18 at 10 52 18 am
joelvh commented 6 years ago

Ah, I see what you were pointing out -- on my phone notification I saw the first couple lines, which have symbol keys.

marcus commented 5 years ago

Gotcha. Javascript has corrupted me :) Thanks for the clarification.