search

avadev / AvaTax-REST-V2-Ruby-SDK

Sales Tax API SDK for Ruby and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
36 stars 56 forks source link

Fixes #81: re-enable setting custom request timeouts #82

Closed oehlschl closed 3 years ago

oehlschl commented 4 years ago

This fixes issue #81 and provides an alternative implementation for PR #72, which caused a regression in the ability for callers to set custom request timeouts.

I covered the default 1200s timeout in a test and asserted it passed before and after the refactor to use DEFAULT_CONNECTION_OPTIONS.

oehlschl commented 4 years ago

Also, I was able to get these specs to pass locally by commenting out the @company_code = companies["value"][0]["companyCode"] line that causes failures in Travis: https://github.com/avadev/AvaTax-REST-V2-Ruby-SDK/blob/master/spec/spec_helper.rb#L25

oehlschl commented 4 years ago

@contygm @shilpa-khanal any chance you could please take a look at this or mention someone who can? it's not urgent, but it is preventing us from upgrading to the latest version. thanks in advance!

christhomson commented 3 years ago

:wave: Any plans to get this merged?

We've also run into a case where we'd like to lower the timeout in our application.

damianlegawiec commented 3 years ago

Any plans on merging this PR?

oehlschl commented 3 years ago

@shilpa-khanal @contygm We (and others) are still unable to upgrade past Avatax v20.1 due to this. Any attention would be greatly appreciated.