search

avadev / AvaTax-REST-V2-Ruby-SDK

Sales Tax API SDK for Ruby and AvaTax REST
https://developer.avalara.com/sdk/
Apache License 2.0
36 stars 56 forks source link

Ruby 2.7 compatibility #90

Closed AlecRust closed 2 years ago

AlecRust commented 3 years ago

When I run tests which use this gem after upgrading Ruby 2.6.6 -> 2.7.2 I get a lot of these warnings in my output:

/Users/alec/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/avatax-20.9.0/lib/avatax/request.rb:31: warning: URI.escape is obsolete
AlecRust commented 3 years ago

Any plans for this @contygm? With Ruby 3.0.0 released it would be good to upgrade to 2.7 a some point.

daralbrecht commented 3 years ago

Any chance of resolving this problem? I would like to switch to Ruby 3.0 but this becomes a blocker for me :/

vinodlala commented 3 years ago

Same here.

AlecRust commented 3 years ago

@shilpakhanal @shilpa-khanal any chance you could review #100 which fixes this?

AlecRust commented 2 years ago

This is done, we're running this gem on Ruby 3.1 successfully. Thanks again!