Formatting, throwing new Exceptions, adding TaxOverride methods.

avadev / AvaTaxClientLibrary

Sales Tax API SDK for C# / DotNet and AvaTax REST

https://developer.avalara.com/sdk/

Apache License 2.0

4 stars 14 forks source link

Formatting, throwing new Exceptions, adding TaxOverride methods. #6

Closed zfrolov closed 7 years ago

zfrolov commented 7 years ago

Please do not merge until I remove the TODOs in the TaxOverride functions. I need to verify the constraints we should enforce after speaking to Manas and/or Tracy.

Created line-level TaxOverride functionality.
Added checks to functions that modify a line to ensure there is a line to work on.
Moved some functions around to maintain order.
Changed commit code to allow user to set their desired flag.
Auto-formatted code.
Minor addition to the example program to use TaxOverrides.

zfrolov commented 7 years ago

Curious about the efficacy of using reflection to get the caller method names. Are there compatibility issues?

ted-spence-avalara commented 7 years ago

@zfrolov - We'd have to test this library in both C# 2.0 and DotNetStandard to ensure it works in both cases. If we have trouble, we can switch back to just using string identifiers. I'm not totally sure it's necessary to identify the function name, as long as the user gets a clear error immediately when using it without any defined lines.

ted-spence-avalara commented 7 years ago

Reviewed with Zhenya and unblocked the merge