avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

fix issue with entrainment from shapefile; fixes #1009 #1012

Closed fso42 closed 1 month ago

fso42 commented 2 months ago

Gives D default indicator if now entTh is given in shapefile and default is being used

pep8speaks commented 2 months ago

Hello @fso42! Thanks for updating this PR.

Line 201:29: E721 do not compare types, use 'isinstance()'

Line 743:121: E501 line too long (130 > 120 characters) Line 334:121: E501 line too long (126 > 120 characters) Line 334:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:' Line 286:121: E501 line too long (132 > 120 characters) Line 259:30: E225 missing whitespace around operator Line 119:121: E501 line too long (128 > 120 characters) Line 76:121: E501 line too long (127 > 120 characters)

Line 854:52: E203 whitespace before ':' Line 849:52: E203 whitespace before ':' Line 766:36: E203 whitespace before ':' Line 765:36: E203 whitespace before ':' Line 485:1: E302 expected 2 blank lines, found 1 Line 474:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 461:18: E711 comparison to None should be 'if cond is not None:' Line 439:1: E302 expected 2 blank lines, found 1 Line 418:46: E711 comparison to None should be 'if cond is not None:' Line 415:33: E711 comparison to None should be 'if cond is not None:' Line 405:43: E711 comparison to None should be 'if cond is None:' Line 337:34: E711 comparison to None should be 'if cond is not None:'

Comment last updated at 2024-08-26 13:08:28 UTC
codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit efec4684 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.8% (0.0% change).

View more on Code Climate.

fso42 commented 1 month ago

Standardtests ok, apart from known kot and hof