Closed fso42 closed 11 months ago
Hello @fso42! Thanks for updating this PR.
avaframe/com1DFA/com1DFATools.py
:Line 269:5: E303 too many blank lines (2) Line 240:6: E203 whitespace before ',' Line 132:20: E124 closing bracket does not match visual indentation Line 100:1: E303 too many blank lines (4)
avaframe/in3Utils/fileHandlerUtils.py
:Line 701:37: E262 inline comment should start with '# ' Line 701:36: E261 at least two spaces before inline comment Line 674:121: E501 line too long (129 > 120 characters)
avaframe/tests/test_com1DFA.py
:Line 209:37: E711 comparison to None should be 'if cond is None:' Line 171:37: E711 comparison to None should be 'if cond is None:'
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
0601e3a
) 73.94% compared to head (2d8b1b8
) 73.93%. Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Code Climate has analyzed commit 2d8b1b86 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 73.9% (0.0% change).
View more on Code Climate.
After discussions today: leave the samosAT name for now, switch when #943 is relevant (i.e. slow phase out)
Standardtests ok
Only representation so far is in the simName, changing samostAT to samosATLarge is missing/ maybe not wanted?