avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

Add L to simName for samosAT; fixes #930 [com1] #940

Closed fso42 closed 11 months ago

fso42 commented 11 months ago

Only representation so far is in the simName, changing samostAT to samosATLarge is missing/ maybe not wanted?

pep8speaks commented 11 months ago

Hello @fso42! Thanks for updating this PR.

Line 269:5: E303 too many blank lines (2) Line 240:6: E203 whitespace before ',' Line 132:20: E124 closing bracket does not match visual indentation Line 100:1: E303 too many blank lines (4)

Line 701:37: E262 inline comment should start with '# ' Line 701:36: E261 at least two spaces before inline comment Line 674:121: E501 line too long (129 > 120 characters)

Line 209:37: E711 comparison to None should be 'if cond is None:' Line 171:37: E711 comparison to None should be 'if cond is None:'

Comment last updated at 2023-11-20 12:11:12 UTC
codecov[bot] commented 11 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0601e3a) 73.94% compared to head (2d8b1b8) 73.93%. Report is 6 commits behind head on master.

Files Patch % Lines
avaframe/in3Utils/geoTrans.py 97.14% 9 Missing :warning:
avaframe/out3Plot/outDebugPlots.py 25.00% 3 Missing :warning:
avaframe/com1DFA/DFAfunctionsCython.pyx 66.66% 1 Missing :warning:
avaframe/com1DFA/com1DFA.py 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #940 +/- ## ========================================== - Coverage 73.94% 73.93% -0.02% ========================================== Files 63 63 Lines 14633 14618 -15 ========================================== - Hits 10821 10808 -13 + Misses 3812 3810 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 2d8b1b86 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (0.0% change).

View more on Code Climate.

fso42 commented 11 months ago

After discussions today: leave the samosAT name for now, switch when #943 is relevant (i.e. slow phase out)

fso42 commented 11 months ago

Standardtests ok