avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

Add new functions to analyze deepDiff results in parameter variation cases [com1] #945

Closed fso42 closed 10 months ago

fso42 commented 10 months ago

fixes #814

pep8speaks commented 10 months ago

Hello @fso42! Thanks for updating this PR.

Line 1590:121: E501 line too long (136 > 120 characters) Line 611:45: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 597:18: E711 comparison to None should be 'if cond is not None:'

Line 184:29: E721 do not compare types, use 'isinstance()'

Comment last updated at 2023-11-30 13:50:52 UTC
codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4ec4c4a) 74.66% compared to head (3d4b856) 74.70%.

Files Patch % Lines
avaframe/com1DFA/com1DFATools.py 92.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #945 +/- ## ========================================== + Coverage 74.66% 74.70% +0.03% ========================================== Files 64 64 Lines 14629 14649 +20 ========================================== + Hits 10923 10943 +20 Misses 3706 3706 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 10 months ago

Code Climate has analyzed commit 3d4b8565 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.7% (0.1% change).

View more on Code Climate.