avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

check warnings in pytest update adding a new column to dfs #949

Closed awirb closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c4ce40b) 74.64% compared to head (689252f) 73.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #949 +/- ## ========================================== - Coverage 74.64% 73.91% -0.74% ========================================== Files 64 64 Lines 14668 14673 +5 ========================================== - Hits 10949 10845 -104 - Misses 3719 3828 +109 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 10 months ago

Hello @awirb! Thanks for updating this PR.

Line 1438:5: E303 too many blank lines (2) Line 1380:19: E711 comparison to None should be 'if cond is not None:' Line 1288:25: E711 comparison to None should be 'if cond is not None:' Line 171:121: E501 line too long (131 > 120 characters) Line 167:131: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 167:121: E501 line too long (140 > 120 characters) Line 69:121: E501 line too long (124 > 120 characters)

Line 501:5: E303 too many blank lines (2) Line 455:9: E265 block comment should start with '# ' Line 446:13: E265 block comment should start with '# ' Line 444:64: E231 missing whitespace after ',' Line 444:38: E231 missing whitespace after ',' Line 441:62: E231 missing whitespace after ',' Line 440:62: E231 missing whitespace after ',' Line 357:121: E501 line too long (128 > 120 characters) Line 350:121: E501 line too long (124 > 120 characters) Line 337:121: E501 line too long (132 > 120 characters) Line 167:13: E117 over-indented Line 152:121: E501 line too long (124 > 120 characters) Line 147:121: E501 line too long (128 > 120 characters) Line 64:121: E501 line too long (122 > 120 characters) Line 59:121: E501 line too long (128 > 120 characters)

Line 461:121: E501 line too long (132 > 120 characters) Line 378:42: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 375:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 86:71: E127 continuation line over-indented for visual indent

Line 1419:35: W292 no newline at end of file Line 1388:1: E303 too many blank lines (3) Line 1342:121: E501 line too long (133 > 120 characters) Line 1342:23: E127 continuation line over-indented for visual indent Line 1341:38: E225 missing whitespace around operator Line 1331:20: E251 unexpected spaces around keyword / parameter equals Line 1279:45: E222 multiple spaces after operator Line 1225:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 1036:121: E501 line too long (121 > 120 characters) Line 1036:41: E225 missing whitespace around operator Line 1013:17: E265 block comment should start with '# ' Line 1013:17: E116 unexpected indentation (comment) Line 1007:9: E265 block comment should start with '# ' Line 949:13: E117 over-indented Line 938:17: E117 over-indented Line 937:12: E111 indentation is not a multiple of four Line 845:67: E127 continuation line over-indented for visual indent Line 706:5: E265 block comment should start with '# ' Line 691:74: E225 missing whitespace around operator Line 685:121: E501 line too long (121 > 120 characters) Line 664:121: E501 line too long (121 > 120 characters) Line 662:9: E265 block comment should start with '# ' Line 655:121: E501 line too long (124 > 120 characters) Line 641:121: E501 line too long (123 > 120 characters) Line 633:121: E501 line too long (138 > 120 characters) Line 380:34: E251 unexpected spaces around keyword / parameter equals Line 358:53: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 332:23: E127 continuation line over-indented for visual indent Line 324:121: E501 line too long (124 > 120 characters) Line 312:17: E265 block comment should start with '# ' Line 312:17: E116 unexpected indentation (comment)

Line 192:121: E501 line too long (149 > 120 characters) Line 184:121: E501 line too long (121 > 120 characters) Line 181:5: E303 too many blank lines (2) Line 161:121: E501 line too long (146 > 120 characters) Line 154:121: E501 line too long (121 > 120 characters) Line 137:32: E231 missing whitespace after ',' Line 24:51: E231 missing whitespace after ',' Line 22:51: E231 missing whitespace after ','

Line 209:37: E711 comparison to None should be 'if cond is None:' Line 171:37: E711 comparison to None should be 'if cond is None:'

Line 15:1: E302 expected 2 blank lines, found 1

Comment last updated at 2023-12-12 08:30:52 UTC
codeclimate[bot] commented 10 months ago

Code Climate has analyzed commit 689252f7 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (-0.6% change).

View more on Code Climate.