search

avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

change finding of velocity threshold indices in aimec for thalweg plots [ana3] #950

Closed awirb closed 10 months ago

awirb commented 10 months ago

change how indVelZero index is found for computation of runoutAngle in thalweg plot (just for plot) angle in dataframe is computed differently as it is based on runoutResType and not on velocity but now same method i used

pep8speaks commented 10 months ago

Hello @awirb! Thanks for updating this PR.

Line 1420:35: W292 no newline at end of file Line 1389:1: E303 too many blank lines (3) Line 1343:121: E501 line too long (133 > 120 characters) Line 1343:23: E127 continuation line over-indented for visual indent Line 1342:38: E225 missing whitespace around operator Line 1332:20: E251 unexpected spaces around keyword / parameter equals Line 1280:45: E222 multiple spaces after operator Line 1226:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 1037:121: E501 line too long (121 > 120 characters) Line 1037:41: E225 missing whitespace around operator Line 1014:17: E265 block comment should start with '# ' Line 1014:17: E116 unexpected indentation (comment) Line 1008:9: E265 block comment should start with '# ' Line 950:13: E117 over-indented Line 939:17: E117 over-indented Line 938:12: E111 indentation is not a multiple of four Line 846:67: E127 continuation line over-indented for visual indent Line 707:5: E265 block comment should start with '# ' Line 692:74: E225 missing whitespace around operator Line 686:121: E501 line too long (121 > 120 characters) Line 665:121: E501 line too long (121 > 120 characters) Line 663:9: E265 block comment should start with '# ' Line 656:121: E501 line too long (124 > 120 characters) Line 642:121: E501 line too long (123 > 120 characters) Line 634:121: E501 line too long (138 > 120 characters) Line 381:34: E251 unexpected spaces around keyword / parameter equals Line 359:53: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 333:23: E127 continuation line over-indented for visual indent Line 325:121: E501 line too long (124 > 120 characters) Line 313:17: E265 block comment should start with '# ' Line 313:17: E116 unexpected indentation (comment)

Line 13:1: E302 expected 2 blank lines, found 1

Comment last updated at 2023-12-20 10:45:20 UTC
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aac21a1) 73.91% compared to head (dabb1b2) 73.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #950 +/- ## ========================================== + Coverage 73.91% 73.92% +0.01% ========================================== Files 64 64 Lines 14673 14675 +2 ========================================== + Hits 10845 10848 +3 + Misses 3828 3827 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 10 months ago

Code Climate has analyzed commit dabb1b26 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (0.0% change).

View more on Code Climate.