Closed awirb closed 8 months ago
Attention: 43 lines
in your changes are missing coverage. Please review.
Comparison is base (
3e709e4
) 73.92% compared to head (cb67a4b
) 73.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @awirb! Thanks for updating this PR.
avaframe/ana4Stats/probAna.py
:Line 800:121: E501 line too long (129 > 120 characters) Line 693:121: E501 line too long (135 > 120 characters) Line 692:121: E501 line too long (167 > 120 characters) Line 628:121: E501 line too long (127 > 120 characters) Line 470:121: E501 line too long (128 > 120 characters) Line 399:121: E501 line too long (121 > 120 characters) Line 188:121: E501 line too long (135 > 120 characters)
avaframe/ana5Utils/distanceTimeAnalysis.py
:Line 314:9: E265 block comment should start with '# ' Line 313:9: E265 block comment should start with '# ' Line 312:9: E265 block comment should start with '# '
avaframe/in3Utils/cfgHandling.py
:Line 386:42: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 383:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
avaframe/in3Utils/cfgUtils.py
:Line 815:28: W292 no newline at end of file Line 627:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 313:37: E231 missing whitespace after ',' Line 92:38: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
avaframe/out3Plot/outQuickPlot.py
:Line 165:48: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
avaframe/runScripts/runEnergyLineTest.py
:Line 46:121: E501 line too long (124 > 120 characters)
avaframe/runScripts/runParticleAnalysisPlots.py
:Line 133:121: E501 line too long (138 > 120 characters) Line 95:1: E265 block comment should start with '# ' Line 94:121: E501 line too long (128 > 120 characters) Line 41:1: E266 too many leading '#' for block comment Line 31:1: E266 too many leading '#' for block comment
avaframe/runScripts/runPlotContoursFromAsc.py
:avaframe/runScripts/runRotationTest.py
:Line 59:121: E501 line too long (124 > 120 characters) Line 54:121: E501 line too long (138 > 120 characters) Line 48:121: E501 line too long (122 > 120 characters)
avaframe/runStandardTestsCom1DFA.py
:Line 103:121: E501 line too long (127 > 120 characters)
avaframe/tests/test_ana1Tests.py
:Line 197:121: E501 line too long (128 > 120 characters)
avaframe/tests/test_probAna.py
:Line 444:121: E501 line too long (122 > 120 characters) Line 117:64: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Code Climate has analyzed commit cb67a4b6 and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 2 |
The test coverage on the diff in this pull request is 76.7% (50% is the threshold).
This pull request will bring the total coverage in the repository to 73.8% (-0.1% change).
View more on Code Climate.
Standardtests ok, apart from avaKot
avaKot is related to change here: #948, accepting for now (new DEM data basis, reporjection ...). Benchmark results need to be updated.
Breaking change for override sections: now need the collection name as well as the module name