avaframe / AvaFrame

https://avaframe.org
European Union Public License 1.2
16 stars 2 forks source link

Add contour line plot [com1; ana5; out3; breaking change] #953

Closed awirb closed 8 months ago

awirb commented 9 months ago

Breaking change for override sections: now need the collection name as well as the module name

codecov[bot] commented 9 months ago

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (3e709e4) 73.92% compared to head (cb67a4b) 73.88%.

Files Patch % Lines
avaframe/out3Plot/outQuickPlot.py 44.44% 25 Missing :warning:
avaframe/in3Utils/cfgHandling.py 91.50% 9 Missing :warning:
avaframe/com3Hybrid/com3Hybrid.py 0.00% 7 Missing :warning:
avaframe/ana5Utils/distanceTimeAnalysis.py 50.00% 1 Missing :warning:
avaframe/out1Peak/outPlotAllPeak.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #953 +/- ## ========================================== - Coverage 73.92% 73.88% -0.05% ========================================== Files 64 64 Lines 14675 14755 +80 ========================================== + Hits 10848 10901 +53 - Misses 3827 3854 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 9 months ago

Hello @awirb! Thanks for updating this PR.

Line 800:121: E501 line too long (129 > 120 characters) Line 693:121: E501 line too long (135 > 120 characters) Line 692:121: E501 line too long (167 > 120 characters) Line 628:121: E501 line too long (127 > 120 characters) Line 470:121: E501 line too long (128 > 120 characters) Line 399:121: E501 line too long (121 > 120 characters) Line 188:121: E501 line too long (135 > 120 characters)

Line 314:9: E265 block comment should start with '# ' Line 313:9: E265 block comment should start with '# ' Line 312:9: E265 block comment should start with '# '

Line 386:42: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 383:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 815:28: W292 no newline at end of file Line 627:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 313:37: E231 missing whitespace after ',' Line 92:38: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 165:48: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 46:121: E501 line too long (124 > 120 characters)

Line 133:121: E501 line too long (138 > 120 characters) Line 95:1: E265 block comment should start with '# ' Line 94:121: E501 line too long (128 > 120 characters) Line 41:1: E266 too many leading '#' for block comment Line 31:1: E266 too many leading '#' for block comment

Line 37:1: W391 blank line at end of file

Line 59:121: E501 line too long (124 > 120 characters) Line 54:121: E501 line too long (138 > 120 characters) Line 48:121: E501 line too long (122 > 120 characters)

Line 103:121: E501 line too long (127 > 120 characters)

Line 197:121: E501 line too long (128 > 120 characters)

Line 444:121: E501 line too long (122 > 120 characters) Line 117:64: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Comment last updated at 2024-01-23 15:49:26 UTC
codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit cb67a4b6 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 76.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.8% (-0.1% change).

View more on Code Climate.

fso42 commented 9 months ago

Standardtests ok, apart from avaKot

fso42 commented 8 months ago

avaKot is related to change here: #948, accepting for now (new DEM data basis, reporjection ...). Benchmark results need to be updated.