[com4FlowPy]: add travel length to output-files

avaframe / AvaFrame

https://avaframe.org

European Union Public License 1.2

16 stars 2 forks source link

Closed PaulaSp3 closed 3 months ago

PaulaSp3 commented 4 months ago

store travel length of every path and save it as output (as CH did in the old repo)

pep8speaks commented 4 months ago

Hello @PaulaSp3! Thanks for opening this PR.

Line 237:5: E722 do not use bare 'except'

Line 486:121: E501 line too long (137 > 120 characters) Line 460:119: W291 trailing whitespace

ahuber-bfw commented 3 months ago

Looks good to me! Just two minor remarks/comments to keep in mind:

Maybe we can think about having the outputs controllable via the .ini file (e.g. provide a list of outputs) --> future feature enhancement
The travel_length output looks reasonable in general, but also has some weird artefacts in some test cases (see picture below) - but this is probably linked to other issues (cell_counts, flux conservation, ...)