pep8speaks
commented
4 months ago Hello @PaulaSp3! Thanks for updating this PR.
- In the file
avaframe/com1DFA/com1DFA.py:
Line 2098:69: E127 continuation line over-indented for visual indent
- In the file
avaframe/com1DFA/deriveParameterSet.py:
Line 735:121: E501 line too long (130 > 120 characters) Line 326:121: E501 line too long (126 > 120 characters) Line 326:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:' Line 278:121: E501 line too long (132 > 120 characters) Line 119:121: E501 line too long (128 > 120 characters) Line 76:121: E501 line too long (127 > 120 characters)
- In the file
avaframe/out3Plot/plotUtils.py:
Line 973:121: E501 line too long (138 > 120 characters) Line 971:19: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 942:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 799:121: E501 line too long (124 > 120 characters) Line 683:37: E203 whitespace before ':' Line 682:37: E203 whitespace before ':' Line 531:15: E711 comparison to None should be 'if cond is not None:' Line 495:71: E203 whitespace before ':' Line 495:48: E203 whitespace before ':' Line 489:71: E203 whitespace before ':' Line 489:48: E203 whitespace before ':' Line 476:121: E501 line too long (121 > 120 characters)
- In the file
avaframe/tests/test_DFAfunctionsCython.py:
Line 626:1: W293 blank line contains whitespace Line 580:1: E305 expected 2 blank lines after class or function definition, found 1 Line 372:33: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 371:72: E225 missing whitespace around operator Line 370:22: E225 missing whitespace around operator Line 353:69: E225 missing whitespace around operator Line 352:73: E225 missing whitespace around operator Line 341:121: E501 line too long (125 > 120 characters) Line 339:121: E501 line too long (179 > 120 characters) Line 339:19: E127 continuation line over-indented for visual indent Line 338:121: E501 line too long (146 > 120 characters) Line 336:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 335:72: E225 missing whitespace around operator Line 334:22: E225 missing whitespace around operator Line 320:39: E225 missing whitespace around operator Line 313:69: E225 missing whitespace around operator Line 312:73: E225 missing whitespace around operator Line 304:59: E241 multiple spaces after ',' Line 301:121: E501 line too long (125 > 120 characters) Line 299:121: E501 line too long (179 > 120 characters) Line 299:19: E127 continuation line over-indented for visual indent Line 298:121: E501 line too long (146 > 120 characters) Line 296:33: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 295:72: E225 missing whitespace around operator Line 294:22: E225 missing whitespace around operator Line 275:121: E501 line too long (126 > 120 characters) Line 273:121: E501 line too long (179 > 120 characters) Line 273:19: E127 continuation line over-indented for visual indent Line 272:121: E501 line too long (146 > 120 characters) Line 270:33: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 269:72: E225 missing whitespace around operator Line 268:22: E225 missing whitespace around operator Line 253:38: E225 missing whitespace around operator Line 237:121: E501 line too long (131 > 120 characters) Line 210:121: E501 line too long (121 > 120 characters) Line 208:121: E501 line too long (179 > 120 characters) Line 208:19: E127 continuation line over-indented for visual indent Line 207:121: E501 line too long (146 > 120 characters) Line 203:43: E241 multiple spaces after ',' Line 202:91: E241 multiple spaces after ',' Line 201:121: E501 line too long (121 > 120 characters) Line 110:1: W293 blank line contains whitespace
- In the file
avaframe/tests/test_com1DFA.py:
Line 2177:29: W292 no newline at end of file Line 219:37: E711 comparison to None should be 'if cond is None:' Line 180:37: E711 comparison to None should be 'if cond is None:'
codeclimate[bot]
fso42
For res-simulation: add option to consider detrainment (instead of resistance or additionally)
add option to get detrained mass as output (colormap for the report/plot does not fit, for resType = dmDet)
write detrained mass per time step in mass balance file
[ ] Docu
[ ] Add additional particle property to doc Note @fso42 : Doc goes into extra PR