avahe-kellenberger / nimdow

A window manager written in Nim (In Development)
GNU General Public License v2.0
317 stars 19 forks source link

Default master width #206

Closed marcusramberg closed 2 years ago

marcusramberg commented 2 years ago

Allow setting default width in percent for master. Can be set per tag.

avahe-kellenberger commented 2 years ago

This is great, but I have two thoughts:

Something like:

[monitors]
  [monitors.default.tags]
  # Set the width of master windows for ALL monitors and tags
  all.defaultMasterWidthPercentage = 60
  # Change the default for the first tag on all monitors
  1.defaultMasterWidthPercentage = 30

  [monitors.1.tags]
  # Set the width of the master window on monitor 1 for all tags
  all.defaultMasterWidthPercentage = 45
  # Set the width of the master window on monitor 1, tag 2
  2.defaultMasterWidthPercentage = 90

  [monitors.2.tags]
  # Setting the width for monitor 2, tag 2
  2.defaultMasterWidthPercentage = 70

We do this currently for displayString and numMasterWindows, for reference

marcusramberg commented 2 years ago

@avahe-kellenberger I've addressed your comments here as well as fixed config reloading to respect this setting now, so I guess we're ready for another review.

avahe-kellenberger commented 2 years ago

I'll check it out by tomorrow, thanks!