Open abheektripathy opened 2 months ago
At the moment there is no ethAddress or availAddress. Also the user address is nullable, to allow querying the entire list of bridge transactions wherever possible. This does not affect the performance in any way, as it is one less filter on the DB query, so I would say it is alright to keep it optional.
@vibhurajeev had a talk with @0xSasaPrsic on this before, userAddress would be changed to ethAddress, availaddress, since i have to query the api twice everytime i need to fetch the transactions on the ui
agree on the optional thing
Instead of passing userAddress
as a query param we can pass 2 query params ethAddress
and availAddress
so that filtering happens on the db level and removes one extra request. If any of those params are not passed then the behavior stays the same.
Do we index AMB Message transactions?
currently, the response from this looks like this
TODOS
the datatype currently is ERC20 it should be FungibleToken // Message, should have the amount when we have a fungible token or else message