search

avaje / avaje-config

Application configuration / properties loading for JVM applications
https://avaje.io/config
Apache License 2.0
51 stars 8 forks source link

Use ServiceLoader for yaml #87

Closed SentryMan closed 1 year ago

SentryMan commented 1 year ago

now people can plug their own yaml parsers. fixes part of #41

sonatype-lift[bot] commented 1 year ago

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

SentryMan commented 1 year ago

hmm

SentryMan commented 1 year ago

perhaps I've become too comfortable with circles(this time I just didn't feel like rewriting all the tests). But this'll work to extract the yml out of the config module so it can be excluded via maven.

rob-bygrave commented 1 year ago

I don't think this change is justified. The premise is the YamlSimpleLoader is large enough to justify removing it out into a separate module.

It's 300 lines, I don't think this justifies pulling it out into a separate module etc.

SentryMan commented 1 year ago

It saves like 10kb if we take it out yeah