Backwards Compatible Generic Modules

avaje / avaje-inject

Dependency injection via APT (source code generation) ala "Server-Side Dagger DI"

https://avaje.io/inject

Apache License 2.0

240 stars 24 forks source link

Backwards Compatible Generic Modules #567

Closed SentryMan closed 5 months ago

SentryMan commented 5 months ago

Adds all the backwards compatibility stuff from #566 minus the SPI changes

rbygrave commented 5 months ago

Did you hit this issue of desiring 10.x to be backwards compatible or did someone else? Just wondering of the pain level. Also just to say I'm kind of not loving "AvajeModule" as a name ... so I'm hoping that something better might come to me.

SentryMan commented 5 months ago

Yeah, I noticed that all the plugins and libraries I've made at work ceased to function

SentryMan commented 5 months ago

Need to resolve why InjectPlugin exists

The maven plugin/generator is unable to get the type array from legacy plugins.

SentryMan commented 5 months ago

don't like "AvajeModule" as a name

I was thinking of AvajeModule sort of like Guice has GuiceModule.

I got a couple of alternate options (just spitballing here):

BeanModule
DIModule
ScopeModule
GraphModule
WiringModule
DependencyModule

rob-bygrave commented 5 months ago

AvajeModule sort of like Guice has GuiceModule

Yeah, that makes sense. IMO the original "Module" was a poor choice by me. "InjectModule" is taken by the annotation (which seems ok) ... so I'm definately warming to AvajeModule (it's mostly used internally).

I should get to review this again today. Great work by the way !!!