avaje / avaje-inject

Dependency injection via APT (source code generation) ala "Server-Side Dagger DI"
https://avaje.io/inject
Apache License 2.0
240 stars 24 forks source link

Refactor SPI interfaces #570

Closed SentryMan closed 5 months ago

SentryMan commented 5 months ago

changes of #566 with only the SPI changes.

Resolves #559

rbygrave commented 5 months ago

I don't think this PR is going to be merged. To me it looks like it contains 3 other different changes that are unrelated what this PR should focus on which would be the introduction to a common service interface. To me the implementation changes include some unexpected code changes that I'll have to walk through slowly to see why they are justified. Hmm.

SentryMan commented 5 months ago

3 other different changes that are unrelated what this PR

I forgot to separate the config change, but what are the other 2? Can you expound?