Rename Property Plugin from PropertyRequiresPlugin to ConfigPropertyPlugin

avaje / avaje-inject

Dependency injection via APT (source code generation) ala "Server-Side Dagger DI"

https://avaje.io/inject

Apache License 2.0

240 stars 24 forks source link

Rename Property Plugin from PropertyRequiresPlugin to ConfigPropertyPlugin #572

Closed SentryMan closed 4 months ago

SentryMan commented 5 months ago

We use it for more than the @RequiresX annotations. Also I don't like the name.

rbygrave commented 5 months ago

I'm pondering if we just go for a simple breaking change here. As in, likely very very few people have implemented this interface (it hasn't been around for a long time etc). So I think it might be acceptable and simple and less messy to just go with a simple rename and breaking change. Pondering ...

SentryMan commented 5 months ago

I'm pondering if we just go for a simple breaking change here.

It'll break every single one of the other avaje plugins that uses configuration if we do a clean break. Like the Jsonb Inject plugin for example