search

avaje / avaje-inject

Dependency injection via APT (source code generation) ala "Server-Side Dagger DI"
https://avaje.io/inject
Apache License 2.0
227 stars 21 forks source link

Refactor rename AvajeModule interface to InjectModule #613

Closed rbygrave closed 2 months ago

rbygrave commented 2 months ago

Note that I think this is reasonable in terms of @InjectModule being the same name in that the IDE auto-completion when using the annotation knows it's an annotation. So I don't think we get problematic use like this.

In the generated code is the one place that we do get the clash using both the annotation and interface and in this case we fully qualify the interface in the generated code.

SentryMan commented 2 months ago

Can't say I'm fan of classes sharing the same name.

rbygrave commented 2 months ago

Yeah, lets not merge this.