search

avajs / ava-codemods

Codemods for AVA
https://ava.li
MIT License
68 stars 16 forks source link

Current master branch won't work if released #26

Closed DrewML closed 8 years ago

DrewML commented 8 years ago

It looks like #24 didn't add account for how the cli would be consumed by users doing npm install -g ava-codemods.

That PR was commited to master a month after the last release, so the version in the npm registry is still ok. But, releasing a new version from master would not work in it's current state.

How would you like me to address this @sindresorhus? Options being:

  1. Revert changes to use ES6
  2. Compile in prepublish to a dist directory and ignore src files for publish
  3. Run babel-register when users run the CLI

3 doesn't seem like the best idea for DX.

jamestalmage commented 8 years ago

babel-register - See https://github.com/avajs/ava-codemods/issues/18#issue-153552933

sindresorhus commented 8 years ago

babel-register

sindresorhus commented 8 years ago

I went with #1. Was just the imports that needed reverting. I couldn't get babel/register to work. Was easier this way. Probably much more performant too.