Closed ghost closed 4 years ago
As you found in #1755 the benchmarks have been broken for over a year… I never actually run them. Perhaps we should get rid of them. @avajs/core?
I think the benchmark could be useful if we have performance-related commits or PRs. I would prefer to just fix them.
:+1: to @sindresorhus
I'd love to work on this if it's still an open issue.
@OTR500miles2go thanks for your interest! I don't mind it being fixed but it feels like wasted effort. It's 14 months since this issue was raised and I've still never tried to run benchmarks.
@sindresorhus?
Yeah, let's just remove them.
May I contribute by submitting a PR to:
/bench
maintaining.md
, remove the benchmark section.gitignore
, remove the bench/.results
entrySounds great @OTR500miles2go!
As Per The
maintaining.md
, I ranBut, the result was