search

avajs / ava

Node.js test runner that lets you develop with confidence 🚀
MIT License
20.74k stars 1.41k forks source link

Problem running benchmarks #1756

Closed ghost closed 4 years ago

ghost commented 6 years ago

As Per The maintaining.md, I ran 

$ node bench/run && node bench/compare

But, the result was

fs.js:928
  return binding.readdir(pathModule.toNamespacedPath(path), options.encoding);
                 ^

Error: ENOENT: no such file or directory, scandir 'E:\Workspace\ava\bench\.results'
    at Object.fs.readdirSync (fs.js:928:18)
    at Object.<anonymous> (E:\Workspace\ava\bench\compare.js:7:16)
    at Module._compile (module.js:649:30)
    at Object.Module._extensions..js (module.js:660:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:501:12)
    at Function.Module._load (module.js:493:3)
    at Function.Module.runMain (module.js:690:10)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:666:3
novemberborn commented 6 years ago

As you found in #1755 the benchmarks have been broken for over a year… I never actually run them. Perhaps we should get rid of them. @avajs/core?

sindresorhus commented 6 years ago

I think the benchmark could be useful if we have performance-related commits or PRs. I would prefer to just fix them.

ghost commented 6 years ago

:+1: to @sindresorhus

OTR500miles2go commented 5 years ago

I'd love to work on this if it's still an open issue.

novemberborn commented 5 years ago

@OTR500miles2go thanks for your interest! I don't mind it being fixed but it feels like wasted effort. It's 14 months since this issue was raised and I've still never tried to run benchmarks.

@sindresorhus?

sindresorhus commented 5 years ago

Yeah, let's just remove them.

OTR500miles2go commented 5 years ago

May I contribute by submitting a PR to:

novemberborn commented 5 years ago

Sounds great @OTR500miles2go!