Closed DavidAnson closed 2 years ago
Documentation for the is assertion uses parameter names value and expected: https://github.com/avajs/ava/blob/6b63b1bc14a1aaa7d4ee4f2201f901624419c677/docs/03-assertions.md#L124
is
value
expected
Declaration for the same assertion uses parameter names actual and expected: https://github.com/avajs/ava/blob/6b63b1bc14a1aaa7d4ee4f2201f901624419c677/types/assertions.d.ts#L190
actual
This is inconsistent. I think actual/expected is more clear and more common, so suggest standardizing on that pairing.
Sounds good to me. Would you like to open a PR @DavidAnson?
Please don't wait for me to send a PR, it's unlikely I'll have time for this soon.
Documentation for the
is
assertion uses parameter namesvalue
andexpected
: https://github.com/avajs/ava/blob/6b63b1bc14a1aaa7d4ee4f2201f901624419c677/docs/03-assertions.md#L124Declaration for the same assertion uses parameter names
actual
andexpected
: https://github.com/avajs/ava/blob/6b63b1bc14a1aaa7d4ee4f2201f901624419c677/types/assertions.d.ts#L190This is inconsistent. I think actual/expected is more clear and more common, so suggest standardizing on that pairing.