search

avajs / eslint-plugin-ava

ESLint rules for AVA
https://avajs.dev
MIT License
230 stars 49 forks source link

Fix integration test #286

Closed fisker closed 4 years ago

sindresorhus commented 4 years ago

Thanks for fixing 👌

fisker commented 4 years ago

Master not running, says Build type disabled via repository settings (push). https://travis-ci.org/avajs/eslint-plugin-ava/requests

Is it because of this line? https://github.com/avajs/eslint-plugin-ava/blob/master/.travis.yml#L12

maybe 

-  - if [ $INTEGRATION == true ]; then npm run integration; fi
+  - if [[ $INTEGRATION == true ]]; then npm run integration; fi
sindresorhus commented 4 years ago

Fixed: https://travis-ci.org/avajs/eslint-plugin-ava/jobs/631839007 Somehow the Travis setting to build on branches was disabled.

    • if [ $INTEGRATION == true ]; then npm run integration; fi
    • if [[ $INTEGRATION == true ]]; then npm run integration; fi

We should still do this though. As [[ is better and to be as close as possible to the Unicorn setup.