Closed fmatray closed 3 years ago
You are correct, The PMS5003ST
has number concentrations, but has_number_concentration
returns false
This error also affects the PMS5003S
and PMS5003T
models.
Only the PMS3003
lacks number concentrations, so the following patch should fix the problem
- inline bool has_number_concentration() { return (status == OK) && (pms == PLANTOWER_32B); }
+ inline bool has_number_concentration() { return (status == OK) && (pms != PMS3003); }
Hi @fmatray
Just committed the patch I mentioned on my previous message.
I do not have a PMS5003ST
to test this so I would appreciate if you could confirm that it works.
Please let me know if you find any other problem.
Once I have your conformation, I'll create a new tag/release.
Cheers, Á.
Thanks a lot. I won't be able to check this correction before mid december.
Cheers, Frédéric
No problem, the new version release can wait.
I received the 5003ST sooner than expected. And this point works.
I received the 5003ST sooner than expected. And this point works.
Great. Thanks for checking
Hello, I think there is an error with has_number_concentration() with PMS5003ST. According to the datasheet, this sensor have concentration datas
I'm not sure yet, as I only have the 7003 for the moment. I'll check when I receive the 5003ST, in 2 weeks.
Thanks.