search

avallete / ag-grid-autocomplete-editor

Quick implementation of autocompletion into ag-Grid cell using autocompleter package.
MIT License
49 stars 25 forks source link

fix(minLength): fix minLength cannot set to 0 #106

Closed ying-zhou-git closed 2 years ago

ying-zhou-git commented 3 years ago

Enable minLength = 0, as it is a different user scenario from showOnFocus.

But there might be a bug in current version, which is fetch cannot be triggered without editing (type or delete) the input, no matter what's the value exists before focus the input cell. Which is why for the cypress test added has to type in something then delete it to empty to show the list. I'm not sure if this is desired performance or not since it's not declared in README. Could you either fix it or make it more clear in README?

matt-kameron commented 2 years ago

Hello, has there been an opportunity to review this pull request?

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: