search

avallete / ag-grid-autocomplete-editor

Quick implementation of autocompletion into ag-Grid cell using autocompleter package.
MIT License
49 stars 25 forks source link

support for ag-grid 25 and typescript #90

Closed DimitarChristoff closed 3 years ago

DimitarChristoff commented 3 years ago

There seem to be some typescript issues with AutoCompleteSellectCellEditor - property gridOptionsWrapper is private but not in type PopupComponent which it extends 

ERROR in C:\dev\ag-grid-autocomplete-editor\ag-grid-autocomplete-editor.ts
./ag-grid-autocomplete-editor.ts
[tsl] ERROR in C:\dev\ag-grid-autocomplete-editor\ag-grid-autocomplete-editor.ts(76,46)
      TS2416: Property 'gridOptionsWrapper' in type 'AutocompleteSelectCellEditor' is not assignable to the same property in base type 'PopupComponent'.
  Type 'GridOptionsWrapper | undefined' is not assignable to type 'GridOptionsWrapper'.
    Type 'undefined' is not assignable to type 'GridOptionsWrapper'.
avallete commented 3 years ago

Error come from this breaking change: https://github.com/ag-grid/ag-grid/blame/53059eb7f771d8c7268a4cd7e070694e8a2a34d9/community-modules/core/src/ts/context/beanStub.ts#L27

gridOptionsWrapper has been moved to beanStubs, which is extended by Component, so we don't need to declare it into the cellEditor anymore.

Juste removing gridOptionsWrapper from the declarations should work. I'll release a fix ASAP.

avallete commented 3 years ago

:tada: This issue has been resolved in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: