Waveform generation causes a zombie process

avalonmediasystem / avalon

Avalon Media System – Samvera Application

http://www.avalonmediasystem.org/

Apache License 2.0

93 stars 51 forks source link

Waveform generation causes a zombie process #3672

Closed joncameron closed 4 years ago

joncameron commented 5 years ago

Description

The cancel method isn't fully killing the ffmpeg process that has been started, and/or leaves a zombie process. This is (naturally!) not ideal.

Done Looks Like

FfmpegAdapter#cancel fully kills the ffmpeg process without leaving any lingering processes

phuongdh commented 4 years ago

Couldn't reproduce on Spruce:

Ingested a file
Wait till processing is half way through
Find running ffmpeg process: there is one
Delete master file from item
Find running ffmpeg process: there is none

cjcolvar commented 4 years ago

I tested again locally under docker and couldn't replicate this behavior either.

cjcolvar commented 4 years ago

Now that we moved the encode job create into a background job we have noticed that this has started happening again.

cjcolvar commented 4 years ago

Looks like the zombie is present on spruce. I'm also seeing this in docker. Probably related to the waveform job again. :(

cjcolvar commented 4 years ago

If we can't fix this right away then we can provide a workaround of restarting sidekiq often which would clean up the zombies. Really really not good, but an option.