avalonmediasystem / avalon

Avalon Media System – Samvera Application
http://www.avalonmediasystem.org/
Apache License 2.0
93 stars 51 forks source link

Hotkeys for keyboards connected to mobile devices #5670

Open elynema opened 4 months ago

elynema commented 4 months ago

Description

As part of 7.7 release, we did a fair amount of hotkey testing on mobile devices. However, hotkeys are not inherently built into mobile devices, and would potentially only be used if a bluetooth keyboard was hooked up to the device. This seems most likely for iPads?

We should investigate best practices for hotkeys for mobile devices with bluetooth keyboards.

The particular area where we found hotkeys on a keyboard don't work on mobile devices is the up/down arrow key for volume control. Instead of raising / lowering volume, it scrolls the screen. In addition, the 'm' hotkey did not work to mute in full-screen Safari on iPad.

The scrolling with use of down arrow key is shown on iPhone in the following video (ignore the accidental full-screen at the beginning):

Private Zenhub Video

For past work, see: https://github.com/avalonmediasystem/avalon/issues/5645

Done Looks Like

Dananji commented 2 months ago

I tested Ramp demo site on Browserstack for the following devices;

Then tested on following physical devices with a Bluetooth keyboard;

NOTE: in mobile devices the player is built with the mute toggle button instead of the volume panel, thus the up/down arrow keys aren't suppose to work in this context. The device's volume buttons are expected to be used to increase/decrease volume.

Dananji commented 2 months ago

@elynema and @joncameron I didn't test this on a physical Android device and I'm not sure whether the behavior in Browserstack can be accepted as working. I think we probably should test it on a physical device. What do you think?

joncameron commented 2 months ago

Testing on a physical device would be nice if possible but I would be satisfied as long as iOS is covered. I unfortunately don't have a physical Android device to test with. I wonder if Library IT has one we could borrow for this purpose.