avalonmediasystem / avalon

Avalon Media System – Samvera Application
http://www.avalonmediasystem.org/
Apache License 2.0
93 stars 51 forks source link

Playlist paging buttons not working on iPhone (Safari) #5869

Closed elynema closed 3 months ago

elynema commented 3 months ago

Description

The buttons to page through playlists on avalon-dev are not working in Safari on iOS (note we test iOS 17 only). This includes both the buttons for individual pages and the prev/next buttons.

These buttons are working fine on Android (Chrome) and in Chrome and Safari on the desktop.

Private Zenhub Video

Done Looks Like

masaball commented 3 months ago

This was being caused by the width of the paging controls dropping them to the next line, where they are covered by the footer. I have a PR to set the footer to a negative z-index to ensure that it will be behind everything else, but should we also adjust the paging controls so that they don't get dropped to the next line?

We would need to change the number of entries dropdown so it does not have explanatory text. And we could lessen the number of pages displayed in the controls. So something like

Screenshot_20240618_145115.png

or

Screenshot_20240618_145240.png
elynema commented 3 months ago

@masaball I think it's ok to remove some of the paging button options, but I think the drop-down for number of results per page really needs to remain with the wording "Show [x] entries." Otherwise it is pretty non-obvious what it is. Does that perhaps mean we still need 2 lines?

elynema commented 3 months ago

Looks like current solution is wrapping to 2 lines and buttons are working, so will probably leave it there for now.