Open elynema opened 2 weeks ago
Dananji is not sure how we could fix this better than we already have. The buttons are supposed to be on an interval that checks every second to see if the player is ready and then enable themselves.
In testing on avalon-staging, I was not able to replicate this issue on iOS Safari (iPhone), so this does feel like a regression. https://avalon-staging.dlib.indiana.edu/media_objects/n009w228g
I tried on iOS Safari and Chrome on Android and could reproduce after many refreshes.
From Google Analytics, I looked at the past 12 months for traffic on /playlists from device category "mobile". Only 10 users on mobile used a /playlist/*/edit route, and 9 users on mobile were recorded for /playlist/new.
Describe the bug Sometimes, the Add to Playlist, Create Timeline, and Create Thumbnail buttons never get enabled on page load. So far, this is seen on Android and iOS mobile devices, mostly after reloading the page numerous times.
Once this happens, reloading the page does not seem to re-enable the buttons. Starting playing the video and then reloading the page may re-enable the buttons.
To Reproduce Steps to reproduce the behavior, including the results:
Expected behavior These buttons should become enabled once the player is ready. We could conceivably enable them immediately on page load in the mobile context, where we seem to be having issues, but if they are enabled too early before the player is ready, they will have bad data and not work properly.
Questions
Environment (please complete the following information):
Release: Is this issue associated with a specific release? [e. g. 7.6]
Additional notes Any additional information or notes that may be helpful in diagnosing or fixing the problem.