avalonmediasystem / avalon

Avalon Media System – Samvera Application
http://www.avalonmediasystem.org/
Apache License 2.0
93 stars 51 forks source link

Fix flakey test in IIIFManifestPresenter spec #5904

Open cjcolvar opened 5 days ago

cjcolvar commented 5 days ago

I've seen two tests fail recently on un-related PRs: spec/models/iiif_manifest_presenter_spec.rb:70 spec/models/iiif_manifest_presenter_spec.rb:74

It appears that it is doing a string include test for randomized strings that could be very short values like "a" leading to false positives. This test probably needs to be refined to do equality matching instead of string inclusion matching (maybe it was assumed to be doing array matching before?).