avalonmediasystem / avalon

Avalon Media System – Samvera Application
http://www.avalonmediasystem.org/
Apache License 2.0
93 stars 51 forks source link

User Inputs for Searching Can Results in Query Errors #6013

Open joncameron opened 1 month ago

joncameron commented 1 month ago

Description

There are two main areas where we see 500 errors in the application from bad URIs:

Is extra handling an option so users get an "not found" page rather than a 500?

Users get a "Sorry, I don't understand your search" for some bad URI requests but not others. The honeybadger error below is an example of this case.

Done Looks Like

cjcolvar commented 1 month ago

See https://app.honeybadger.io/projects/54117/faults/104411152/01J6AH2VTFA9B23ZB9P0W5229A#notice-summary for an example of a search that doesn't get the user input sanitized enough and ends up breaking the solr query.

joncameron commented 1 month ago

These cases could also be caught in the ApplicationController so that users get redirected to the home page across the board when making bad requests.