avalonmediasystem / avalon

Avalon Media System – Samvera Application

http://www.avalonmediasystem.org/

Apache License 2.0

93 stars 51 forks source link

Bad encode status shouldn't break encode dashboard #6018

Open cjcolvar opened 2 weeks ago

cjcolvar commented 2 weeks ago

Description

In production there were a few records which had received nil statuses for unknown reasons. This caused the encode dashboard to break (index and view pages) when it attempted to display one of these records. I manually fixed the statuses in the rails console but the dashboard shouldn't break when bad data is encountered.

See https://app.honeybadger.io/projects/54117/faults/101593057 and https://app.honeybadger.io/projects/54117/faults/110202917

How should the dashboard display if there is a nil value?
Is investigation needed for encodes returning nil?

Done Looks Like

[ ] 'nil' status for encodes doesn't prevent encode dashboard from rendering

joncameron commented 2 weeks ago

Potentially a bug in ActiveEncode or time drift between expected duration and ffmpeg output causing the nil state.