avalonmediasystem / avalon

Avalon Media System – Samvera Application

http://www.avalonmediasystem.org/

Apache License 2.0

94 stars 51 forks source link

Pull in new version of timeliner #6077

Open elynema opened 1 month ago

elynema commented 1 month ago

Description

Timeliner has now been updated so that it can run with a newer version of Node. Can we now pull this newer version into Avalon?

Done Looks Like

[x] Testing done on the Timeliner staging instance
[ ] Newest Timeliner build brought into Avalon
[ ] Testing done with Timeliner in avalon-dev

joncameron commented 1 month ago

CSS changes have been made in addition to the build pipeline updates: https://github.com/IUBLibTech/timeliner/commit/3b19d48f5c633016aec2b1b8a7f00ab0e258bd5a

cjcolvar commented 2 weeks ago

The build now produces two different files for both CSS and JS: man and app. It appears that both are needed and I'm not sure if I was including them both correctly. One approach I took was inlining the main files into the app files. I think this was mostly working, but I ran into two errors:

markers aren't rendering on the time rail in the correct places instead they appear below one another at the far left of the rail
slider controls (volume and bubble height) aren't changeable and the volume slider isn't the full width it was before

elynema commented 2 weeks ago

I'm going to pull this out of 8.0 for now; if we find a fix for it in the next 2 weeks, we can slide it into a later release candidate. Otherwise, we can pull to next release.

cjcolvar commented 2 weeks ago

It looks like timeliner-staging has the same issues I noted above so this isn't Avalon specific.