search

avamsi / Flash

Flash is a highly parallel downloading client with support for multiple source IP addresses / network adapters
12 stars 3 forks source link

Use less number of threads #4

Open avamsi opened 7 years ago

avamsi commented 7 years ago

Flash currently creates 8 NUMBER_OF_IP_ADDRESSES threads per download* (the number of threads increases with each download, even in the same instance of the app).

While I never really had any problems with the current design, it is, admittedly, lazy. The number of threads should optimally be same as NUMBER_OF_IP_ADDRESSES per instance.

j3rwin commented 7 years ago

Will there be any increase in performance if it is changed to 1(from 8)?

avamsi commented 7 years ago

Performance increase, as in more download speed? No. Performance increase, as in less load on the CPU? Yes.

j3rwin commented 7 years ago

Okk. Asked you because I felt that increasing the no.of IPs beyond a certain point is decreasing the download speed so I thought decreasing threads might also increase the speed :p