avanisubbiah / material-you-theme

Applies generated libadwaita theme from wallpaper using Material You
GNU General Public License v3.0
249 stars 20 forks source link

Light theme is applied to dark-themed applications when the system theme is light #21

Open workonfire opened 2 years ago

workonfire commented 2 years ago

As the title says. I can see why this happens, but I'd like to use some apps with a dark theme while the system theme stays light.

Expected behavior:

System theme is light, while in apps where the theme should be dark, this extension should use the dark variant instead of the light one. For example, there's Tilix where I have the dark theme explicitly enabled. With my green wallpaper and global light theme enabled, it should look like this: image image

Current behavior:

image image

Also, the contrast in dropdown menus is a bit odd.

allaeddineomc commented 2 years ago

the solution will be for the extension to generate both a dark and a light style sheets instead of a single one and setting it ts the theme , this will also fix the apps not switching dark and light themes till they are closed and reopened

sidevesh commented 2 years ago

I looked into this issue and @allaeddineomc seems to be right, generating both dark and light style sheets would solve this issue for a lot of apps which have manual dark and light mode toggles including the new Gnome text editor, Gnome Console and others, @avanishsubbiah I also saw https://github.com/GradienceTeam/Gradience/issues/12 which might be relevant for this too.