search

avanzu / AdminThemeBundle

Admin Theme based on the AdminLTE Template for easy integration into symfony
MIT License
280 stars 148 forks source link

Update adminlte version in composer.json #177

Closed Big-Shark closed 7 years ago

shakaran commented 7 years ago

@Big-Shark Thanks for your contribution! But accoriding to composer.json documentation if I accept this Pull Request it will make that with the "Tilde Version Range" that you pick AdminLTE between 2.3.0 and 3.0.0, and it seems that there is problems with 2.4 version which is the reason of issue https://github.com/avanzu/AdminThemeBundle/issues/175. So I have to reject because it will make other users problems, unless that the problems with 2.4 would be resolved too. Reopen or discuss if you still have another point of view with this, I could be wrong.

shakaran commented 7 years ago

Reopening since reading the docs again, I see that putting ~2.3.0 will be equivalent to >=2.3.0 and <2.4.0 which should satisfy and don't break for issue #175