search

avanzu / AdminThemeBundle

Admin Theme based on the AdminLTE Template for easy integration into symfony
MIT License
281 stars 149 forks source link

Set null default value to max #191

Closed pabloveintimilla closed 6 years ago

pabloveintimilla commented 6 years ago

This avoid this error: Type error: Too few arguments to function Avanzu\AdminThemeBundle\Event\NotificationListEvent::__construct(), 0 passed in /var/www/html/cti/vendor/avanzu/admin-theme-bundle/Controller/NavbarController.php on line 39 and exactly 1 expected

pabloveintimilla commented 6 years ago

@shakaran i understand that the variable "max" is useful to set maximun number of notifications displayed in panel, is correct?. If this is correct y recommend set null that represent without limit

shakaran commented 6 years ago

@pabloveintimilla after check the code, it seems that it is not really used in any place that set the maximum of notification.

I update other events using getMax() that probably have the same issue. https://github.com/avanzu/AdminThemeBundle/commit/f1395240a55b381fe7cad79ecaa09d4814694abf

And added some phpdoc: https://github.com/avanzu/AdminThemeBundle/commit/d273c8387a080a484e8d112df5cfd446ff475444

Thanks for your contribution!