Spinjs fixed - Githubissues

avanzu / AdminThemeBundle

Admin Theme based on the AdminLTE Template for easy integration into symfony

MIT License

281 stars 149 forks source link

Spinjs fixed #198

Closed danielroehrig-mm closed 6 years ago

danielroehrig-mm commented 6 years ago

➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖

⚠️⚠️⚠️ THIS BUNDLE HAS ENTERED INTO ITS FEATURE FREEZE PERIOD ⚠️⚠️⚠️

Pull Requests with New Features will no longer be merged.
If you want to propose some new feature, please create an Issue.
Pull Requests that fix bugs are still accepted and greatly appreciated.

➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖➖

As @rmisos already pointed out, SpinJs was rewritten in TypeScript.

shakaran commented 6 years ago

@danielroehrig-mm sorry, same as PR @rmisos you are adding more commits in the history than the needed. If you or @rmisos cannot rewrite it, I will push the change directly to master

danielroehrig-mm commented 6 years ago

I see, but I'm also confused since I have only made one commit. It was in a branch from tag 1.3.7 though, so this might be the problem. Let me try it again, this time branching from master.

Am Fr, 10. Nov, 2017 um 2:53 P. M. schrieb Ángel Guzmán Maeso notifications@github.com:

@danielroehrig-mm sorry, same as PR @rmisos you are adding more commits in the history than the needed. If you or @rmisos cannot rewrite it, I will push the change directly to master

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

shakaran commented 6 years ago

Closing in favour of #199