Symfony 3.4 and 4 compatibility

[kevinpapst]

After upgrading to Symfony 4 the AdminThemeBundle stopped working (see #215 as well). All twig files could not be loaded with the current reference style, it always ended up with an exception like "The file AvanzuAdminThemeBundle:Default:index.html.twig could not be found".

I did a quick research but couldn't find out why the template loader stopped working with the current syntax in master. It worked for me in 3.3, but stopped after the migration to SF4.

If I read the docs for the latest versions:

• https://symfony.com/doc/current/templating.html#referencing-templates-in-a-bundle
• https://symfony.com/doc/3.4/templating.html#referencing-templates-in-a-bundle

both versions say

If you need to refer to a template that lives in a bundle, Symfony uses the Twig namespaced syntax (@ BundleName/directory/filename.html.twig).

I clearly understand if you @shakaran don't want to risk BC breaks and reject the merge (for now), but I though I leave that PR for others users who want to upgrade to Symfony 4 and have troubles getting their site up again.

[kevinpapst]

If someone wants to test it, add

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/kevinpapst/AdminThemeBundle"
        }
    ]

to your composer json and reference

"avanzu/admin-theme-bundle": "dev-symfony4",

I am going to keep that fork updated until this PR might eventually be merged to master.

[craph]

It's also development for compatibility with SF 3.4

This PR must be accepted !!

[craph]

@shakaran , @avanzu : Please could you accept this PR it's really important for compatibility with SF 3.4 et 4 !!

[shakaran]

@craph SF 3.4 and SF 4 is not supported at this moment, until this bundle gets released in branch 2.x, so the support will not happen until the branch 3.x will be created. You can always fork or merge this PR in your personal repository if you urgently need some feature or PR

[craph]

@shakaran why you doesn't open à branch 3.x to get this PR and release the branch 2.x ?

What is the release date plan ?

[Isarien]

Hello, Do you have any news about this PR and the 3.0 branch ?

[shakaran]

@craph @Isarien Take in mind that I am a collaborator here, author of some commits and mostly taking the project and helping to avanzu to maintain this project almost a year now (in a altruist mode by the way) since he has no time. So I am freelancer too and I have high work load sometimes (also I maintain more projects in altruist mode). So sorry if it is not delivered or checked quickly like a commercial project, but I am trying to do my best and add more pressure or angry comments (that I understand, since I am in the other side too for other projects), probably doesn't help to solve more quickly the issues.

Anyways, I created a new branch called https://github.com/avanzu/AdminThemeBundle/tree/experimental-symfony-3.4-4.x

For play and merge new things or PR. Even with that, Symfony 3.4 and 4.x is evolving quickly and more in the bundle world. So the plan is still get a stable version for Symfony 2.x and 3.[1,2,3] in the branch 2.x. Then deprecated the branch 1.x of this project. After that focus in new branch 3.x for Symfony new versions.

[tacman]

I've been using the branch that @kevinpapst provided -- can you make him a collaborator, so he can integrate his branch and moderate its development too?

At this point, would vote to skip Symfony 3.4 support and go completely with Symfony4 for that branch, and include webpack encore for the js/css. We can also upgrade to fontawesome 5 and bootstrap 4 and have a modern stack for this theme.

FWIW, I didn't interpret any of the comments posted here as angry. Enthusiastic, perhaps, but not angry, I think everyone appreciates what's being done.

I'm happy to contribute on the Symfony side, maybe in working on a demo repo that replaced AdminLTE but with Symfony (datatables, fosUserBundle, etc.) I've been using Kevin's timesheet repo as an example of how to use this bundle, and I keep thinking there must be a better way to demonstrate it.

On Wed, May 16, 2018 at 2:41 PM, Ángel Guzmán Maeso < notifications@github.com> wrote:

@craph https://github.com/craph @Isarien https://github.com/Isarien Take in mind that I am a collaborator here, author of some commits and mostly taking the project and helping to avanzu to maintain this project almost a year now (in a altruist mode by the way) since he has no time. So I am freelancer too and I have high work load sometimes (also I maintain more projects in altruist mode). So sorry if it is not delivered or checked quickly like a commercial project, but I am trying to do my best and add more pressure or angry comments (that I understand, since I am in the other side too for other projects), probably doesn't help to solve more quickly the issues.

Anyways, I created a new branch called https://github.com/avanzu/ AdminThemeBundle/tree/experimental-symfony-3.4-4.x

For play and merge new things or PR. Even with that, Symfony 3.4 and 4.x is evolving quickly and more in the bundle world. So the plan is still get a stable version for Symfony 2.x and 3.[1,2,3] in the branch 2.x. Then deprecated the branch 1.x of this project. After that focus in new branch 3.x for Symfony new versions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/avanzu/AdminThemeBundle/pull/216#issuecomment-389623741, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl0QQ8BYvtcooRYbCLBVh2Ou3ZzMP5Gks5tzHLMgaJpZM4Rc7Re .

[kevinpapst]

@shakaran what do you think about opening an "official" SF4 branch?

I cannot really maintain all the changes in my personal branch - for example the complete frontend build in my repository is now based on webpack-encore.

In my opinion this bundle brings some unnecessary "bloat" and is missing some really important things on the other hand (I don't want to go into details here, as that would be too much out-of-scope discussion), so a SF4 branch could also be used as a "fresh start".

Do you have an opinion on SF4 support? Or in other words: is SF4 on your roadmap for 2018?

If you dislike the idea of maintaining SF4, I could also imagine to create a new repo for SF4.

[tacman]

+1 for a new repo, based on weback-encore, Symfony4.1 (to include the 'help' field in forms), and if possible, fontawesome 5. Bootstrap 4 would be a plus, but that's hard, because AdminLTE is still based on bootstrap3.

On Thu, Jun 21, 2018 at 12:43 PM, Kevin Papst notifications@github.com wrote:

@shakaran https://github.com/shakaran what about opening an "official" SF4 branch?

I cannot really maintain all the changes in my personal branch - for example the complete frontend build in my repository is now based on webpack-encore.

In my opinion this bundle brings too much internal "bloat" and is missing some really important things on the other hand (I don't want to go into details here, as that would be too much out-of-scope discussion), so a SF4 branch could also be used as a "fresh start".

If you dislike the idea, I could also imagine to create a new repo for SF4 maintenance.

Do you have an opinion here? Or in other words: Is SF4 on your roadmap for 2018?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/avanzu/AdminThemeBundle/pull/216#issuecomment-399168847, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl0QVrrWj-ujPyjrc7CnWnOFWzZriRJks5t-80bgaJpZM4Rc7Re .

[kevinpapst]

As I couldn't wait any longer, I had to fork this bundle for upgrading it to Symfony 4: https://github.com/kevinpapst/AdminLTEBundle It is based on Symfony 4, incorporates FontAwesome 5 and uses Webpack-Encore for building the assets - more information in the linked repo.

[numerogeek]

Hi, So now if we want to update to SF 3.4 we have to use your bundle @kevinpapst ? @shakaran you don't want to merge the PR ta keep this bundle alive ?

[kevinpapst]

From my understanding @shakaran wants to focus on the BC compatibility. Please note, that my bundle is not fully compatible with this one. So there is no "switch composer packages and you are good to go" mode available.

[numerogeek]

Ow Ok thank you, @kevinpapst Do you have a migration guide or something ? @avanzu @shakaran : why not relaease a version for sf 2.8 and create a new release that require sf 3.4 ? IMHO we should stick with LTS versions.

[shakaran]

All this changes has been merged now via https://github.com/avanzu/AdminThemeBundle/commit/f0a9637a69639ed2fcd38f4a18470399b6ef3db5

In the new branch "experimental-symfony-4.x"

https://github.com/shakaran/AdminThemeBundle/tree/experimental-symfony-4.x

Since I am having some problems for update the packagist.org package (I already requested to be maintainer to avanzu main owner, but it could take time to it), I am maintaining the same commits and duplicating the work in a personal repo and packagist account:

composer require shakaran/admin-theme-bundle:dev-experimental-symfony-4.x

https://packagist.org/packages/shakaran/admin-theme-bundle