search

avanzu / AdminThemeBundle

Admin Theme based on the AdminLTE Template for easy integration into symfony
MIT License
280 stars 148 forks source link

Avanzu 1.3.8 : crash with update of font awesome to version 5.x #225

Closed sylvaincombes closed 6 years ago

sylvaincombes commented 6 years ago

Hello,

In the bower file there is an * for the font awesome version, it crashes assets building because files have changed their path, changing to :

"fontawesome"               : "4.*",

Correct the issue. I haven't submitted a pull request as I haven't found from which branch i should start, here is the file and line to correct :

https://github.com/avanzu/AdminThemeBundle/blob/ed9a11f4c002bbc542adb680bddc5222e11e85a6/Resources/bower/bower.json#L31

Thank you for your work

sylvaincombes commented 6 years ago

see : #224

shakaran commented 6 years ago

Duplicated. Thanks for your report. Closing this.

sylvaincombes commented 6 years ago

Hi first thank you for your time, I really need to have this patch on your 1.3.x versions as I rely on this for multiple projects, can you please make it happen or give me instructions to be able to send a pull request and having a proper 1.3.8.1 or 1.3.9 version of your bundle ?

shakaran commented 6 years ago

@sylvaincombes just run:

composer update

It should pick you the new 1.3.9 just released unless that you have cached something

sylvaincombes commented 6 years ago

Great ! 👍 Thank you very much !