search

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Custom Adapter #102

Closed sohayb closed 8 years ago

sohayb commented 9 years ago

Hello, Are you planning to add custom adapter rather than just setting items? for, let's say, items having images in addition to titles. Thanks

davidvavra commented 9 years ago

Hi, it makes sense to add this functionality to ListDialogFragment. We don't plan to do it, but we would accept a pull request.

Just beware that it's tricky, because Adapter needs a Context for inflating it's views. And you don't want to leak Activity Context after a configuration change (rotation). So the custom Adapters would probably need to implement some interface which would take care of setting the Context.

syrakozz commented 9 years ago

+1

davidvavra commented 8 years ago

@sohayb Any updates regarding to a pull request?

sohayb commented 8 years ago

I'm sorry, but didn't have any time to implement that :/

davidvavra commented 8 years ago

And do you thing you will find time?

sohayb commented 8 years ago

Unfortunately I can't give a definitive answer :(

davidvavra commented 8 years ago

I'm trying to clean up issues. So let's close it and feel free to reopen if you find time.