search

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Migrated to AndroidX #142

Closed MonikaJethani closed 5 years ago

MonikaJethani commented 5 years ago

Migrated project containing library and demo modules to AndroidX.

MonikaJethani commented 5 years ago

@sakulisko Please review this PR.

sakulisko commented 5 years ago

Hi, thanks for PR. To pass CI please try to update .travis.yml with this content

language: android
script: "./gradlew assembleDebug"
android:
  components:
    - build-tools-28.0.3
    - android-28
    - extra-android-m2repository
MonikaJethani commented 5 years ago

Hi, thanks for PR. To pass CI please try to update .travis.yml with this content

language: android
script: "./gradlew assembleDebug"
android:
  components:
    - build-tools-28.0.3
    - android-28
    - extra-android-m2repository

Hi @sakulisko. travis file is updated and checks are passed. All other review comments have been implemented. Please do a final review and merge. Thanks.

sakulisko commented 5 years ago

@MonikaJethani Thank you for you contribution.