search

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Allow to use ISimpleDialogCancelListener and ISimpleDialogListener with any dialog #17

Closed tprochazka closed 10 years ago

tprochazka commented 11 years ago

ISimpleDialogCancelListener and ISimpleDialogListener is very powerfull way to handle user response in fragment or activity level in save way (handle orientation change). But now is possible use it only with SimpleDialogFragment and it's not good think to use SimpleDialogFragment as parent for new custom dialogs. It is not designed for that.

davidvavra commented 11 years ago

What would you suggest? We should not have two ways of creating custom dialogs. Maybe move something from SimpleDialogFragment to BaseDialogFragment?

tprochazka commented 11 years ago

Yes, best way is move support ISimpleDialogCancelListener and ISimpleDialogListener to BaseDialogFragment

tomas-vondracek commented 10 years ago

@tprochazka BaseDialogFragment is too general for ISimpleDialogListener - it may not contain anything that would result in positive/negative response. We could move support for ISimpleDialogCancelListener to BaseDialogFragment, but I prefer to keep those listeners together in one class. Closing for now. You can reopen the issue, if you had better idea.