search

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Add setHtmlMessage methods #21

Closed franklinharper closed 10 years ago

franklinharper commented 10 years ago

Hi David,

In SimpleDialogFragment I changed the type of mMessage from String to CharSequence.

This is because Html.fromHtml(String) returns a Spanned, and not a String. Both Spanned and String implement CharSequence, so I think it works the way I wrote it this time.

Sorry it took some time to write this minor patch. It is my first contribution to OSS project, so I had to learn how to do some things in git.

Best, Frank

davidvavra commented 10 years ago

Thanks a lot. CharSequence should work, it's nice that you didn't change public API, just extended it.